Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT/#5] 온보딩 뷰 / 카카오 연결 #13

Merged
merged 22 commits into from
Jul 6, 2024
Merged

[FEAT/#5] 온보딩 뷰 / 카카오 연결 #13

merged 22 commits into from
Jul 6, 2024

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Jul 6, 2024 •
edited
Loading

⛳️ Work Description

  • 카카오 SDK 연결
  • 카카오가 없을 시 웹으로 실행
  • 로그인 시 정상적으로 작동하는 지 확인

📸 Screenshot

Screen_Recording_20240706_174931_Terning-Android.mp4

📢 To Reviewers

  • 로그인 뷰는 임시로 처리해뒀어요! 다시 UI 수정할겁니당
  • 해당 PR 머지하면 디코 안드 채널에 올려둔 걸로 로컬프로퍼티 수정해주세요!!! (확인했으면 디코에 체크표시 부탁함요!)

leeeyubin added 14 commits July 4, 2024 17:55
@leeeyubin leeeyubin added FEAT ✨ 새로운 기능 구현 유빈💙 유빈 labels Jul 6, 2024
@leeeyubin leeeyubin added this to the 1차 스프린트 UI 작업 milestone Jul 6, 2024
@leeeyubin leeeyubin self-assigned this Jul 6, 2024
arinming
arinming approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SignInViewModel 보면서 진짜 감탄했어요,, StateFlow 랑 친해질 수 있을 것 같아용 최고 ㅜㅜ!!!!

feature/src/main/java/com/terning/feature/onboarding/signin/SignInRoute.kt
.size(500.dp),
)
KakaoButton(
title = stringResource(id = R.string.sign_in_kakao_button),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[where]_[what] 네이밍 컨벤션 다시 한 번 확인합니당!

feature/src/main/java/com/terning/feature/onboarding/signin/component/KakaoButton.kt
Row(
modifier = modifier
.fillMaxWidth()
.background(Color.Yellow)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거는 안드 디자인 시스템 Yellow 임의로 사용하신 건가용?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네! 임의로 사용했습니당 추후에 로그인 뷰 UI 구현할 때 수정할게요!!!

boiledEgg-s
boiledEgg-s approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 우리 리드!! 코드 멀끔하네요:)
SideEffect, Flow 등 이거 참고해서 공부해야겠네용

Hyobeen-Park
Hyobeen-Park approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 역시 우리 리드 최고다👍🏻👍🏻 저두 이거 참고해서 공부할게요😎

app/src/main/java/com/terning/point/MyApp.kt Outdated
@@ -1,9 +1,12 @@
package com.terning.point

import android.app.Application
import android.util.Log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 지금 쓰고 있는거 아니면 빼도 될 것 같아요!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예리하다,,,,,수정하겠습니당~!!

@leeeyubin leeeyubin merged commit 0c48be2 into develop Jul 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@arinming arinming arinming approved these changes

Assignees

@leeeyubin leeeyubin

Labels
FEAT ✨ 새로운 기능 구현 유빈💙 유빈
Projects
None yet
Milestone
1차 스프린트 UI 작업
Development

Successfully merging this pull request may close these issues.

[FEAT] 온보딩 뷰 / 카카오 연결
4 participants
@leeeyubin @arinming @Hyobeen-Park @boiledEgg-s